Closed stramel closed 1 year ago
Latest commit: 184e4f2d2f108bd04a5f31374e58573e3f0882d4
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
api-astroicon | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 6, 2023 2:26am |
astroicon | ❌ Failed (Inspect) | Jun 6, 2023 2:26am |
Hey! I'm not sure if it's intentional or not, but it seems this doesn't quite get all the way. I see you've added the new option here:
But it looks like that never actually gets passed here: https://github.com/natemoo-re/astro-icon/blob/184e4f2d2f108bd04a5f31374e58573e3f0882d4/packages/core/src/vite-plugin-astro-icon.ts#L28
Oh, looks like it may have been a bad merge conflict resolution. Thank you for pointing this out @charlie-hadden!
This is a pretty simple new feature that will allow consumers to pass their own
svgo
options.I did notice that specifically there was an issue where
title
is removed during theimportDirectory
call and prevents a consumer from being able to disable theremoveTitle
plugin insvgo
to keep thetitle
tag.Fixes #68