search

natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
995 stars 57 forks source link

[v1] feat: allow configuring the icon attribute #101

Closed stramel closed 1 year ago

stramel commented 1 year ago

Provides a way to change the icon attribute from astro-icon to a custom one. Typically, users want a data-* attribute to be compliant with an HTML validator.

Fixes #55

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: e8cce17ff94157665865ee50a669ad34f1bdbc96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api-astroicon ❌ Failed (Inspect) May 24, 2023 3:51am
astroicon ❌ Failed (Inspect) May 24, 2023 3:51am
natemoo-re commented 1 year ago

I don't think we need to allow customization here, v1 will just use a standard-friendly data-icon attribute!