natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
1.08k stars 60 forks source link

perf(createIconPack): improve local icon resolution #149

Closed kripod closed 10 months ago

kripod commented 11 months ago

The existence of a file shouldn’t be checked in advance, as that doesn’t guarantee that the given file can actually be read. Therefore, our best bet is to just try reading directly from the file and then handle errors.

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: ff52d59f482f6fe677fc93e71045007b07e92074

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------- | ----- | | astro-icon | Patch | | www | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 7:39pm
astroicon ❌ Failed (Inspect) Dec 5, 2023 7:39pm