search

natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
990 stars 57 forks source link

fix: inherit viewbox width / height of none provided #186

Closed gavar closed 5 months ago

gavar commented 5 months ago

Currently if no width or height attributes provided to Icon component - it receives some weird rem units. This fix allows inheriting view box values if no width / height is provided.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 4:47am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 4:47am
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 582fb3b8e4125162b70729b3ad8787fc202c3158

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gavar commented 5 months ago

@natemoo-re could you please take a look?