Add support for passthrough attributes

natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!

https://astroicon.dev

Other

990 stars 57 forks source link

Add support for passthrough attributes #202

Open natemoo-re opened 5 months ago

natemoo-re commented 5 months ago

WIP, but the goal is to allow presentational attributes to be applied directly to the rendered icon. The main use case is stroke-width, but there might be others that I haven't seen yet!

Still TODO

[ ] make sure sprites are handled properly
[ ] less hacky replacement behavior (ultrahtml for parsing?)
[ ] Handle true / false attribute values
[ ] Handle injecting the value when the attribute does not already exist

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: cf2f5eb7a0ee7b213fb64ee325f8188d66d150e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------- | ----- | | astro-icon | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api-astroicon	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 2, 2024 7:57pm
astroicon	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 2, 2024 7:57pm