Open Harry-Ross opened 2 months ago
Latest commit: 01b546285664c044df53ad9fa5c4f99f72ed3f08
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
api-astroicon | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 14, 2024 10:15am |
astroicon | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 14, 2024 10:15am |
Nice PR, if this was already included, it would've saved me an hour of troubleshooting...
Yes i was just troubleshooting this issue
Fixes #213
width
,height
andsize
able to accept astring
value as well as anumber
value (i.e. for usingrem
,px
, etc.)However, this is similar to the inherent attributes associated with an![image](https://github.com/natemoo-re/astro-icon/assets/20507092/3f33ab54-c1a2-4493-bf91-e304713a60ad)
<svg>
tag:So - an alternate solution may be just removing these attributes from the props entirely, and just relying on the
extends HTMLAttributes<"svg">
instead.