natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
990 stars 57 forks source link

Types - Added Better Typings for Width, Height + Size #219

Open Harry-Ross opened 2 months ago

Harry-Ross commented 2 months ago

Fixes #213

However, this is similar to the inherent attributes associated with an <svg> tag: image

So - an alternate solution may be just removing these attributes from the props entirely, and just relying on the extends HTMLAttributes<"svg"> instead.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 01b546285664c044df53ad9fa5c4f99f72ed3f08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | astro-icon | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 10:15am
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2024 10:15am
Chinoman10 commented 3 weeks ago

Nice PR, if this was already included, it would've saved me an hour of troubleshooting...

Mgrdich commented 6 days ago

Yes i was just troubleshooting this issue