natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
1.08k stars 60 forks source link

feat: pass props to custom resolver #42

Closed germanz closed 1 year ago

germanz commented 2 years ago

The following PR passes Icon properties down to custom resolver in order to allow building custom asset URLs that depend not only on icon name, but also size.

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 73cb90e1628f0704ebc8b9406bac4a1516fad5b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------- | ----- | | astro-icon | Minor | | www | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api-astroicon ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 4:27PM (UTC)
astroicon ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 4:27PM (UTC)
germanz commented 2 years ago

Hi @natemoo-re, please take a look when you have time.

germanz commented 2 years ago

Thanks for adding a changeset. Will make sure to add next time ;). Is there anything else needed from my side, or you'll merge?

ghost commented 2 years ago

@natemoo-re, can you merge this please 🙏 ?

edv-ns commented 2 years ago

@natemoo-re Can we have this released please? 🙏