natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
1.01k stars 57 forks source link

Upgrade SVGO to v3 #76

Closed TheOtterlord closed 1 year ago

TheOtterlord commented 1 year ago

I've gone through the changelog for SVGO v3, and tested my changes with a copy of the demo & an up-to-date Astro v1.8.0 project that used astro-compress

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 547d523699738398fcb5e5ba203806ded5c33228

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------- | ----- | | astro-icon | Minor | | www | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 2:48pm
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 2:48pm
dkotik commented 1 year ago

Please merge :-)

stramel commented 1 year ago

I think this would be okay as a minor bump for the existing package code. The v1 branch already has the SVGO v3 integrated.

Are there any side-effects from updating to v3?

stramel commented 1 year ago

Thanks for this PR! At this time we're going to forego this and focus on the v1 since this has a workaround and we have published a next version of astro-icon that includes using svgo@v3