natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
995 stars 57 forks source link

fix: move no sprite log to debug level #85

Closed germanz closed 1 year ago

germanz commented 1 year ago

Moved message to debug level as in some scenarios when Sprite.Provider is used inside a common Astro Layout component, server is bloated with many false positive logs about the missing sprite.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 7d81c0cc3f22a5adf38b14f0309d544314a60bc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------- | ----- | | astro-icon | Patch | | www | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 4:43PM (UTC)
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 4:43PM (UTC)
germanz commented 1 year ago

Hi @natemoo-re, I'd love to see this merged if possible.

stramel commented 1 year ago

@germanz Did you verify that this change fixes your issue? Would this have any unintended side-effects for other users?

stramel commented 1 year ago

Thanks again for this PR! At this time we're going to forego this and focus on the v1.