natemoo-re / astro-icon

Inline and sprite-based SVGs in Astro made easy!
https://astroicon.dev
Other
996 stars 57 forks source link

[v1] Add a standalone Icon component, and some other improvements. #88

Closed santiagocezar closed 1 year ago

santiagocezar commented 1 year ago

Improves DX by not having to enable the integration and manually include icon packs (on SSG environments at least).

The other improvements include:

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: b9bf432898f9bfac60f968fdfa5d43f2cf6c09a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 6:02PM (UTC)
astroicon ❌ Failed (Inspect) Mar 16, 2023 at 6:02PM (UTC)
stramel commented 1 year ago

@santiagocezar What's the benefit of the StandaloneIcon vs IntegratedIcon? Is there a need to differentiate them?

stramel commented 1 year ago

@santiagocezar I used a lot of it as inspiration for getting the v1 into the shape it is in now. We're going to skip the extra component without using integration right now for the initial release. If there is a demand for using the icon without the integration, we can revisit it in the future! Thanks again for this PR!