natemoo-re / microsite

Do more with less JavaScript. Microsite is a smarter, performance-obsessed static site generator powered by Preact and Snowpack.
https://npm.im/microsite
MIT License
877 stars 16 forks source link

Fix incorrect field used for aliases from snowpack user config #136

Closed ratorx closed 3 years ago

ratorx commented 3 years ago

Uses the wrong field from userConfig. According to snowpack.config.js documentation, the aliases field is called just alias and not aliases.

I've just changed it in this PR, but it might be worth loading both for now (for backwards compatibility) and dropping the incorrect field in a new release?

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: 11968d19f9d85b2d40e028568bbc834bf3a24115

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package or glob expression "@example/*" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

microsite-examples – ./

🔍 Inspect: https://vercel.com/nmoo/microsite-examples/5ogB5uWH5rBim8ytE9h4ETRdkZTX
✅ Preview: Failed

microsite – ./site

🔍 Inspect: https://vercel.com/nmoo/microsite/2aCXFm9LjcT6U5zPmmsgeLa5qZDp
✅ Preview: Canceled

natemoo-re commented 3 years ago

Thank you for catching this! I'm going to merge into the v1.1.0 branch, which I'm hoping to cut a release of as soon as Snowpack drops v3.1.0!