search

natemoo-re / tslint-stencil

Contributes some helpful tslint rules for Stencil projects
https://projects.natemoo.re/tslint-stencil/
MIT License
22 stars 4 forks source link

Type errors in componentMemberOrderRule.ts #11

Closed natemoo-re closed 5 years ago

natemoo-re commented 5 years ago

@patricksevat, I missed this on #6, but ran into some Typescript errors when trying to cut a new release. I'll have a fix shortly—just wanted to be sure it's tracked.

In componentMemberOrderRule.ts#L227, groups is typed as ComponentMetadata[], but the block below seems to treat groups as string[].

patricksevat commented 5 years ago

@natemoo-re thanks for letting me know. I saw that, was planning to create a new PR when I get home from work, but leave it to you now. But do let me know if you get stuck, am glad to help