search

natemoo-re / tslint-stencil

Contributes some helpful tslint rules for Stencil projects
https://projects.natemoo.re/tslint-stencil/
MIT License
22 stars 4 forks source link

lifeCycle hooks are incomplete #15

Open chrisweight opened 5 years ago

chrisweight commented 5 years ago

StencilJS has a number of lifecycle hooks documented and available that are not a part of this lint ruleset.

Ref: https://stenciljs.com/docs/component-lifecycle

natemoo-re commented 5 years ago

Thanks for opening this!

I haven't had much time to up with the changes for stencil@one, but I will do my best to fix this soon.

claviska commented 5 years ago

Looks like these ones are missing:

Will updating these constants be sufficient or is there more work under the hood to implement a fix?

pixelbucket-dev commented 5 years ago

There is a new one componentShouldUpdate(). https://github.com/ionic-team/stencil/pull/1876

LalitKushwah commented 4 years ago

@natemoo-re Please find the PR for this https://github.com/natemoo-re/tslint-stencil/pull/17