search

natemoo-re / tslint-stencil

Contributes some helpful tslint rules for Stencil projects
https://projects.natemoo.re/tslint-stencil/
MIT License
22 stars 4 forks source link

fix(componentMemberOrder): fixed watch-follows-props / grouping for multiple watched props #5

Closed patricksevat closed 5 years ago

patricksevat commented 5 years ago

Hi Nate,

Thanks for creating tslint-stencil!

Our team is currently implementing it and we are running into a couple issues. This PR is the first of a couple I will create over the next few days. Hopefully you are open to PRs. I've tried to keep changes to a minimum, but this PR specifically needed some extra lines to not get hacky.

I've already spotted some other stuff that my changes will simplify, so I might refactor those if you'd like that.

If I can improve the PRs in any way please let me know.

Thanks, Patrick

natemoo-re commented 5 years ago

Very open to PRs, thank you! I have been totally swamped lately, so the help is much appreciated—feel free to refactor whatever looks like it can be simplified.

patricksevat commented 5 years ago

Thanks for the quick merges!