search

natenorberg / monstercheckout_rails

A rewrite of the MONSTER checkout app using Ruby on Rails
0 stars 1 forks source link

'Select All' option when creating new permission type not working #12

Closed jcs224 closed 9 years ago

jcs224 commented 9 years ago

With the latest release candidate, I'm unable to select all the equipment when creating a reservation type. Very weird.

screen shot 2014-09-22 at 12 04 27 pm

natenorberg commented 9 years ago

Does it still not work after refresh is clicked? I'm wondering if that's another turbo links issue

jcs224 commented 9 years ago

You are right. The change I made fixed the header, but caused this to happen. Dangit.

jcs224 commented 9 years ago

Played around with that tag a bunch, and it appears to not be the turbolinks option, but the javascript include. My theory is that one particular part of the javascript needs to be right before the closing body tag, whereas the rest needs to be in the head. Will investigate.

natenorberg commented 9 years ago

Thanks Joe. I know it's just that something's getting initialized out of order or not getting refreshed when it needs to.

natenorberg commented 9 years ago

Do you want me to just add you as a contributor so you can just push to the repo or would you rather use pull requests?

natenorberg commented 9 years ago

It seems like this specific issue has been fixed already with the javascript include being moved back to the bottom of application.html.erb There is a separate issue where the dropdown for the user settings doesn't work every other time the page changes, but I can't figure out why and there's an easy fix for it.

Closing this issue