nateosher / DIMPLE

MIT License
2 stars 1 forks source link

Non symmetric dist #100

Closed mariamasotti1 closed 1 year ago

nateosher commented 1 year ago

Going over the tests now. @mariamasotti1 what was the reasoning for adding the varargs (...) to various calls? This seems to be the cause of at least some of the failing tests

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (0701ef4) 96.44% compared to head (21755bb) 96.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #100 +/- ## ========================================== + Coverage 96.44% 96.47% +0.02% ========================================== Files 35 35 Lines 1183 1190 +7 ========================================== + Hits 1141 1148 +7 Misses 42 42 ``` | [Files Changed](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [R/QuantileDist.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9RdWFudGlsZURpc3QuUg==) | `100.00% <ø> (ø)` | | | [R/MakeDistMat.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NYWtlRGlzdE1hdC5S) | `100.00% <100.00%> (ø)` | | | [R/MltplxDist.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhEaXN0LlI=) | `100.00% <100.00%> (ø)` | | | [R/MltplxExperiment.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhFeHBlcmltZW50LlI=) | `97.28% <100.00%> (+0.01%)` | :arrow_up: | | [R/MltplxObject.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhPYmplY3QuUg==) | `97.46% <100.00%> (ø)` | | | [R/update\_dist.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui91cGRhdGVfZGlzdC5S) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.