nateosher / DIMPLE

MIT License
2 stars 1 forks source link

Qdist analysis #19

Closed jeliason closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 51.27% // Head: 51.01% // Decreases project coverage by -0.26% :warning:

Coverage data is based on head (0edff68) compared to base (da16b61). Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #19 +/- ## ========================================== - Coverage 51.27% 51.01% -0.26% ========================================== Files 30 30 Lines 589 590 +1 ========================================== - Hits 302 301 -1 - Misses 287 289 +2 ``` | [Impacted Files](https://codecov.io/gh/nateosher/DistDist/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [R/plot\_pairwise\_group\_heatmap.R](https://codecov.io/gh/nateosher/DistDist/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9wbG90X3BhaXJ3aXNlX2dyb3VwX2hlYXRtYXAuUg==) | `0.00% <0.00%> (ø)` | | | [R/MltplxExperiment.R](https://codecov.io/gh/nateosher/DistDist/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhFeHBlcmltZW50LlI=) | `86.25% <100.00%> (+0.53%)` | :arrow_up: | | [R/MltplxObject.R](https://codecov.io/gh/nateosher/DistDist/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhPYmplY3QuUg==) | `68.57% <100.00%> (-0.52%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jeliason commented 1 year ago

@nateosher the drop in test coverage is pretty small - can we set some sort of threshold so that the codecov check can still pass even if there is an X% decrease in coverage?

jeliason commented 1 year ago

@nateosher my previous comment is not a pressing issue by the way, don't need to worry about this right now.

nateosher commented 1 year ago

@nateosher my previous comment is not a pressing issue by the way, don't need to worry about this right now.

Sorry, just saw this. I'll look into changing these settings.

jeliason commented 1 year ago

@mariamasotti1 how does this look now?

mariamasotti1 commented 1 year ago

I think this is the best solution! thanks!