nateosher / DIMPLE

MIT License
2 stars 1 forks source link

save q_fac mask. #25

Closed jeliason closed 1 year ago

jeliason commented 1 year ago

@mariamasotti1 What do you think about saving this data here for the mask, so we don't have to duplicate later?

codecov[bot] commented 1 year ago

Codecov Report

Base: 51.01% // Head: 51.42% // Increases project coverage by +0.41% :tada:

Coverage data is based on head (c64a7af) compared to base (249c020). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #25 +/- ## ========================================== + Coverage 51.01% 51.42% +0.41% ========================================== Files 30 30 Lines 590 595 +5 ========================================== + Hits 301 306 +5 Misses 289 289 ``` | [Impacted Files](https://codecov.io/gh/nateosher/DistDist/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [R/QuantileDist.R](https://codecov.io/gh/nateosher/DistDist/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9RdWFudGlsZURpc3QuUg==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mariamasotti1 commented 1 year ago

Yeah I don't see why not. I'm also wondering if it would be useful to have a function that only computes the q_fac - to allow quick iterations / visualizations of different q_probs or mask_types without having to calc the entire distance matrices. Thoughts @jeliason ?

jeliason commented 1 year ago

@mariamasotti1 just pulled that functionality out into its own function, lmk what you think.

mariamasotti1 commented 1 year ago

Yes I like it!