Closed jeliason closed 1 year ago
Base: 51.01% // Head: 51.42% // Increases project coverage by +0.41%
:tada:
Coverage data is based on head (
c64a7af
) compared to base (249c020
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Yeah I don't see why not. I'm also wondering if it would be useful to have a function that only computes the q_fac - to allow quick iterations / visualizations of different q_probs or mask_types without having to calc the entire distance matrices. Thoughts @jeliason ?
@mariamasotti1 just pulled that functionality out into its own function, lmk what you think.
Yes I like it!
@mariamasotti1 What do you think about saving this data here for the mask, so we don't have to duplicate later?