search

nateosher / DIMPLE

MIT License
2 stars 1 forks source link

Added tests for lm_qdist/misc documentation #43

Closed nateosher closed 1 year ago

nateosher commented 1 year ago

@jeliason I think I figured out the error! Will send an email

jeliason commented 1 year ago

Thanks @nateosher ! What do you recommend for helping this test pass? Changing the agg function? Using more slide ids per patient?

nateosher commented 1 year ago

Would it be alright if I just made a new pull request with some equivalent tests, and we can merge that? I actually think the two patients per group is a good test data set

jeliason commented 1 year ago

Sounds good to me! Thanks!

Joel Eliason

On Tue, Mar 14, 2023, 1:28 PM nateosher @.***> wrote:

Would it be alright if I just made a new pull request with some equivalent tests, and we can merge that? I actually think the two patients per group is a good test data set

— Reply to this email directly, view it on GitHub https://github.com/nateosher/DistDist/pull/43#issuecomment-1468527046, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC44PS3N2BNSF7LMWKFW6CTW4CTE7ANCNFSM6AAAAAAVZNGB5Y . You are receiving this because you were mentioned.Message ID: @.***>

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +4.92 :tada:

Comparison is base (b4c673b) 64.71% compared to head (1de0617) 69.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #43 +/- ## ========================================== + Coverage 64.71% 69.64% +4.92% ========================================== Files 33 33 Lines 751 751 ========================================== + Hits 486 523 +37 + Misses 265 228 -37 ``` [see 3 files with indirect coverage changes](https://codecov.io/gh/nateosher/DistDist/pull/43/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.