nateosher / DIMPLE

MIT License
2 stars 1 forks source link

Updated SimulateGrid + tests + added as_MltplxExperiment generic #85

Closed nateosher closed 1 year ago

nateosher commented 1 year ago

I updated a few major things here:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 :tada:

Comparison is base (bfcf8e7) 95.21% compared to head (e7c338f) 95.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #85 +/- ## ========================================== + Coverage 95.21% 95.38% +0.17% ========================================== Files 32 32 Lines 898 932 +34 ========================================== + Hits 855 889 +34 Misses 43 43 ``` | [Impacted Files](https://codecov.io/gh/nateosher/DIMPLE/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [R/MltplxExperiment.R](https://codecov.io/gh/nateosher/DIMPLE/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhFeHBlcmltZW50LlI=) | `93.79% <100.00%> (+0.69%)` | :arrow_up: | | [R/MltplxImage.R](https://codecov.io/gh/nateosher/DIMPLE/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhJbWFnZS5S) | `100.00% <100.00%> (ø)` | | | [R/MltplxObject.R](https://codecov.io/gh/nateosher/DIMPLE/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9NbHRwbHhPYmplY3QuUg==) | `97.29% <100.00%> (ø)` | | | [R/SimulateGrid.R](https://codecov.io/gh/nateosher/DIMPLE/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9TaW11bGF0ZUdyaWQuUg==) | `100.00% <100.00%> (ø)` | | | [R/generics.R](https://codecov.io/gh/nateosher/DIMPLE/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9nZW5lcmljcy5S) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mariamasotti1 commented 1 year ago

this looks good I fixed one typo and committed it