search

nateosher / DIMPLE

MIT License
2 stars 1 forks source link

adding boxplots and scatter plots for quantile specific distances #93

Closed mariamasotti1 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 89.18% and project coverage change: -0.49 :warning:

Comparison is base (b696bf6) 96.34% compared to head (7e591d9) 95.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ========================================== - Coverage 96.34% 95.86% -0.49% ========================================== Files 32 35 +3 Lines 1013 1087 +74 ========================================== + Hits 976 1042 +66 - Misses 37 45 +8 ``` | [Impacted Files](https://app.codecov.io/gh/nateosher/DIMPLE/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [R/plot\_qdist\_scatter.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9wbG90X3FkaXN0X3NjYXR0ZXIuUg==) | `77.77% <77.77%> (ø)` | | | [R/plot\_qdist\_boxplots.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9wbG90X3FkaXN0X2JveHBsb3RzLlI=) | `88.23% <88.23%> (ø)` | | | [R/patient\_boxplots\_qdist.R](https://app.codecov.io/gh/nateosher/DIMPLE/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9wYXRpZW50X2JveHBsb3RzX3FkaXN0LlI=) | `94.87% <94.87%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nateosher commented 1 year ago

It looks like this would really tank the coverage; would you mind writing some tests? Or would you want me to?

mariamasotti1 commented 1 year ago

Yes I can do that!

From: nateosher @.> Sent: Monday, May 15, 2023 10:58:30 AM To: nateosher/DIMPLE @.> Cc: Maria Masotti @.>; Author @.> Subject: Re: [nateosher/DIMPLE] adding boxplots and scatter plots for quantile specific distances (PR #93)

External Email - Use Caution

It looks like this would really tank the coverage; would you mind writing some tests? Or would you want me to?

— Reply to this email directly, view it on GitHubhttps://github.com/nateosher/DIMPLE/pull/93#issuecomment-1548029216, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A227BRIC32DYN7FKLEIMO6TXGJABNANCNFSM6AAAAAAYCEEDXE. You are receiving this because you authored the thread.Message ID: @.***>

Electronic Mail is not secure, may not be read every day, and should not be used for urgent or sensitive issues