nateraw / Lda2vec-Tensorflow

Tensorflow 1.5 implementation of Chris Moody's Lda2vec, adapted from @meereeum
MIT License
107 stars 40 forks source link

Issue installing Lda2vec #17

Closed melodywolk closed 5 years ago

melodywolk commented 5 years ago

Running python setup.py build seems to work Then ``python setup.py install``` throws the error

byte-compiling build/bdist.linux-x86_64/egg/lda2vec/Lda2vec.py to Lda2vec.pyc
  File "build/bdist.linux-x86_64/egg/lda2vec/Lda2vec.py", line 84
    self.x, self.y, self.docs, self.additional_features, self.step, self.switch_loss, self.pivot, self.doc, self.context, self.loss_word2vec, self.fraction, self.loss_lda, self.loss, self.loss_avgs_op, self.optimizer, self.doc_embedding, self.topic_embedding, self.word_embedding, self.nce_weights, self.nce_biases, self.merged, *kg = handles
                                                                                                                                                                                                                                                                                                                                         ^
SyntaxError: invalid syntax

Thanks for the help!

Au3C2 commented 5 years ago

In the README.md it said:

Installation Currently, the setup.py and the pip install are both not working! Unfortunately, I suggest you unpack the files yourself, for now. I am actively looking for help fixing that problem!


I think you can run the load_20newsgroups.py to preproccess the dataset, and then run the run_20newsgroups.py to train and test it. BUT I suggest you not to do that, because there are still a lot of issues with this code. For more imformation you can look for other issues.

nateraw commented 5 years ago

Thank you @Au3C2. This code was never meant to be productionized, as it is a research algorithm (noted in the original paper as such, as well). For this reason, as well as me not having so much experience with setting up a custom library, I have not put so much stress on making that part of the code work. Welcome to any pull requests that fix such issues. Thanks again.

Au3C2 commented 5 years ago

Thank you @Au3C2. This code was never meant to be productionized, as it is a research algorithm (noted in the original paper as such, as well). For this reason, as well as me not having so much experience with setting up a custom library, I have not put so much stress on making that part of the code work. Welcome to any pull requests that fix such issues. Thanks again.

Still looking forward to your improvement!

schatimo commented 5 years ago
byte-compiling build/bdist.linux-x86_64/egg/lda2vec/Lda2vec.py to Lda2vec.pyc
  File "build/bdist.linux-x86_64/egg/lda2vec/Lda2vec.py", line 84
    self.x, self.y, self.docs, self.additional_features, self.step, self.switch_loss, self.pivot, self.doc, self.context, self.loss_word2vec, self.fraction, self.loss_lda, self.loss, self.loss_avgs_op, self.optimizer, self.doc_embedding, self.topic_embedding, self.word_embedding, self.nce_weights, self.nce_biases, self.merged, *kg = handles
                                                                                                                                                                                                                                                                                                                                         ^
SyntaxError: invalid syntax

Are you using Python 2.x or >=3.5? E.g. see https://www.python.org/dev/peps/pep-3132/

nateraw commented 5 years ago

Well, it took me a while, but the Pypi install is working again, I believe. Please make a new issue if you have problems installing via pip install lda2vec