search

natergj / excel4node

Node module to allow for easy Excel file creation
MIT License
1.38k stars 215 forks source link

Adds support for xml 1.1 valid characters... like emoji #232

Closed mschnee closed 6 years ago

mschnee commented 6 years ago

This addresses #75

TLDR: the original regex in stringSetter did not properly support 2-char unicode, missing the trailing /u in the regex.

In addition, the character ranges were set up for XML 1.0, not 1.1.

natergj commented 6 years ago

Thanks for the PR, @mschnee! I should have a new version with this change published to NPM today.