search

natergj / excel4node

Node module to allow for easy Excel file creation
MIT License
1.38k stars 215 forks source link

Fix complex string issue described at #269. Way 1. #270

Closed xlazex closed 5 years ago

xlazex commented 5 years ago

It's the first of two pull requests able to fix issue #269.

Pros and Cons of both ways are described in code comments.

xlazex commented 5 years ago
natergj commented 5 years ago

Thanks for finding the root cause of this issue @xlazex! looking over the two solutions you presented, I think a third might be easiest. I'm switched over the lookups to use Javascript Maps. Since those can use any type for the key, it should have the benefit of both solutions. A unique lookup value as the md5 solution without creating the duplicate string entries as this solution. I've opened up https://github.com/natergj/excel4node/pull/276. Let me know your thoughts in that PR

natergj commented 5 years ago

closing in favor of https://github.com/natergj/excel4node/pull/276