nateshmbhat / touchable

The only flutter library to add gestures and animations to custom shapes you draw on your canvas.
https://pub.dev/packages/touchable
Mozilla Public License 2.0
233 stars 80 forks source link

Add support for Null Safety #21

Closed RegisSaffi closed 3 years ago

RegisSaffi commented 3 years ago

This is not a bug or issue, but i wanted to upgrade my current application to Flutter 2, but detected that Touchable does not have support for null safety.

It could be good if this package upgraded to null safety in case someone want to upgrade to Flutter 2

nateshmbhat commented 3 years ago

Yes will work on it today itself.

nateshmbhat commented 3 years ago

Adding null safety support his week 👍🏻

RegisSaffi commented 3 years ago

This will be awesome 😎

nateshmbhat commented 3 years ago

this is the branch if anyone wants it right now : https://github.com/nateshmbhat/touchable/tree/null-safety-migration

nateshmbhat commented 3 years ago

Published the package here : https://pub.dev/packages/touchable/versions/1.0.0-prerelease

Please test and let me know if you guys find any issues. I will publish it was a proper release version then 👍🏻

RegisSaffi commented 3 years ago

Thanks for pre-release, let me test it and i will confirm

nateshmbhat commented 3 years ago

cool 👍🏻

nateshmbhat commented 3 years ago

@RegisSaffi were you able to test it ?

whiplashoo commented 3 years ago

Using it in production (with a few lines commented out) for the past few days, no issues found.

nateshmbhat commented 3 years ago

@whiplashoo please mention what lines did you comment and why

whiplashoo commented 3 years ago

@nateshmbhat Should have worded it out better: I am using it with some of the gesture listeners (onForcePress, onPan, onSecondaryTap) deactivated for my particular use case. This has nothing to do with the null safety update; everything works as expected.

nateshmbhat commented 3 years ago

cool

On Mon, Apr 12, 2021 at 12:30 PM Minas Giannekas @.***> wrote:

@nateshmbhat https://github.com/nateshmbhat Should have worded it out better: I am using it with some of the gesture listeners (onForcePress, onPan, onSecondaryTap) deactivated for my particular use case. This has nothing to do with the null safety update; everything works as expected.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nateshmbhat/touchable/issues/21#issuecomment-817541929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRTSNQPI4UMKDTJFPOC5HDTIKLCFANCNFSM42KB3YRQ .

RegisSaffi commented 3 years ago

Hey, Sorry for late reply but as of now I am not having any issue with the pre-release version.

nateshmbhat commented 3 years ago

Released touchable null safe version 1.0.0 ✌🏻