Update project to better match PEP 8 rules.

nateshmbhat / webbot

Web automation library for simple and easy end to end testing and web browser automation that offers super charged features while keeping it simple to use and master

https://pypi.org/project/webbot/

Mozilla Public License 2.0

239 stars 87 forks source link

Update project to better match PEP 8 rules. #39

Closed Paszymaja closed 3 years ago

Paszymaja commented 4 years ago

reformat code to match PEP 8
deleted semicolons
optimised imports
removed redundant parentheses
updated deprecated selenium code
made docstrings more readable
changed self.error to [] because it's faster
fixed gramma

Paszymaja commented 3 years ago

but what @nateshmbhat thinks ;)

nateshmbhat commented 3 years ago

Hey thanks so much for your contribution. I will review these changes in a week or so. Fully Occupied with work right now.

Meanwhile can u tell me about how u applied the code changes as per pep8 ? Did u change it manually or used a tool or something ?

Paszymaja commented 3 years ago

I used jetbrains pycharm built in refactor tools and some things (semicolons, deprecated selenium code) I changed by hand.

nateshmbhat commented 3 years ago

@Paszymaja can u resolve the conflicts in this branch?

Paszymaja commented 3 years ago

@nateshmbhat I resolved the conflicts.

nateshmbhat commented 3 years ago

Thank you so much for your wonderful contribution 🥳 😄