search

natevm / BSDF-Visualizer

Project for scientific visualization
MIT License
18 stars 4 forks source link

Select on surface #9

Closed DQLin closed 6 years ago

DQLin commented 6 years ago

Hi everyone, just merged my select-on-surface function with nathan's disney brdf. Approval requested.

n8xm commented 6 years ago
  1. We might be better off creating a pull request directly onto my branch (disney-brdf-load). That way it is easier to see which changes are yours and which changes are mine.
  2. Picking is broken on Chromium on Linux. It works on Firefox on Linux but the teapot disappears after clicking between 3 and 10 times. On Windows, it works fine in Firefox. For some reason my Chrome on Windows is choking - can @n8vm test this?
  3. Right now we aren't updating the sliders on the left when we pick.
  4. Ideally, I think we should be moving the light when we pick. The incident ray should point in the light direction.
  5. This is a very handy feature but it might not be the highest priority right now. After I am done loading Disney's .brdfs (which should be around today), I'm going to draft a planning document. Then we can decide whether to continue to fix picking or if we want to focus on some other feature.
n8xm commented 6 years ago

Update on priorities. I'd hate to see @DQLin 's work go to waste. My point is that if it takes a really long time to debug on Linux we may want to move on. EDIT: We can keep the code for Windows and leave it broken on Linux if it's really hard to fix... supporting many platforms is a little outside the scope of a class project.

natevm commented 6 years ago

BRDF's specular lobe isn't pointing towards the light direction. Any idea why this might be?

I might have messed up the selection by changing the aspect ratio of the gl canvases to take into account the additional controls. Could you take a look when you get a chance?

image In the image above, I'd like the specular lobe to point to the upper left.