search

natevw / fatfs

Standalone FAT16/FAT32 filesystem implementation in JavaScript
47 stars 13 forks source link

Add method for creating volume label #31

Closed andrzejressel closed 1 year ago

andrzejressel commented 4 years ago

This PR adds method createLabel that will create special file for volume label that will be detected by blkid after latest changes.

I've tested it with my fork of Xen Orchestra: https://github.com/jereksel/xen-orchestra/tree/label and Ubuntu 20.04

Fixes #30

natevw commented 4 years ago

Hi sorry for the delay on this. I think this is a good start and a reasonable approach overall, but have lots of specific feedback I'll add on the PR itself soon. (About to hop on yet another meeting call…)

marlluslustosa commented 4 years ago

I tested this branch and recompiled XO locally and it didn't work. Is that functional?

andrzejressel commented 4 years ago

I tested this branch and recompiled XO locally and it didn't work. Is that functional?

Yeah, it should work fine. Could you please provide output of blkid /dev/cdrom and dosfslabel /dev/cdrom. I think you could also try to debug cloud-init. I can't remember how I've done it, but you can invoke only source search.

andrzejressel commented 4 years ago

Sorry that it took so long. I've fixed PR all comments

marlluslustosa commented 4 years ago

Cool. I am currently working to fix this on cloudinit. I have now sent patch patches to cloudinit both to see LABEL and LABEL_FATBOOT in their own scripts.

I hope to see this resolved by both parties as soon as possible. You can check my update here: https://bugs.launchpad.net/cloud-init/+bug/1841466/comments/5 thanks!

natevw commented 1 year ago

D'oh! Sorry to let this one linger, but thanks for cleaning it up if it's no longer needed.