search

natevw / node-chargify

Simple wrapper around Chargify's REST API for node.js
17 stars 12 forks source link

Stricter JSON parse when content-type header is application/json. #2

Closed willwhite closed 11 years ago

willwhite commented 11 years ago

Just a little fix to address a problem we had during the Chargify datacenter migration last weekend. Their API was not returning a complete response and therefore the JSON was invalid. Instead of being caught at the source, the unpatched code would allow the body to slip by as a string, causing potential havoc downstream when code get a string instead of an object.

Would love to get this in a release if you have a moment, @natevw.

Thanks!

natevw commented 11 years ago

Ah, hmm. Forgot this had switched over to mikeal's request library...so is req.body normally converted automatically and our code is just a backup? Was going to just clean up and release a minor update but please could you look into this? (I'm in CET and really must be sleeping now, but will try move this forward in my morning.)

willwhite commented 11 years ago

Hi @natevw. I really appreciate you looking at this so quickly. I replied to inline comments above. Happy to discuss more tomorrow and have a good night.

natevw commented 11 years ago

Heh, didn't realize that this lib was still v0.2 so just a minor release should suffice. Just npm published version 0.3.0.

willwhite commented 11 years ago

Cheers. Again, grateful for the fast response.