search

nateware / redis-objects

Map Redis types directly to Ruby objects
Artistic License 2.0
2.09k stars 229 forks source link

Let lock to use redis_options method #262

Open glasses618 opened 2 years ago

glasses618 commented 2 years ago

I encountered the same issue as https://github.com/nateware/redis-objects/pull/157 solved, but is for lock method. I am not sure why https://github.com/nateware/redis-objects/pull/157 didn't let lock to use redis_options, but I think it should be.

This PR introduce redis_options on lock methods and add some test cases. P.S. I didn't add test case on sorted_set because it didn't have any options yet. https://github.com/nateware/redis-objects/blob/054c537700e99a27be6b99bfa691351d070dbc5e/spec/redis_objects_model_spec.rb#L6-L16

codecov[bot] commented 2 years ago

Codecov Report

Merging #262 (e475d14) into master (054c537) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          19       19           
  Lines         944      944           
=======================================
  Hits          933      933           
  Misses         11       11
Impacted Files Coverage Δ
lib/redis/objects/locks.rb 97.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 054c537...e475d14. Read the comment docs.