Add edit task support - Githubissues

natewong1313 / bird-bot

A Nintendo Switch checkout bot. Currently supports Walmart and Best buy

MIT License

1.18k stars 336 forks source link

Add edit task support #17

Closed jaredkaczynski closed 4 years ago

jaredkaczynski commented 4 years ago

Creates CreateDialog when edit button clicked
Loads CreateDialog with task data and disables quantity
On edit task clicked, update task data, refresh UI labels, delete task from JSON, re-add task to JSON

raman325 commented 4 years ago

Thanks for submitting this! I rebased master on both this and your other PR, but I noticed that edit doesn't load the profile list correctly. Just an FYI!

jaredkaczynski commented 4 years ago

Thanks for submitting this! I rebased master on both this and your other PR, but I noticed that edit doesn't load the profile list correctly. Just an FYI!

What does it load on your end, can you be more descriptive? Does the proxies load properly? Are the proxies and profiles loaded properly in the original Create Task menu? The fields are pulled directly from this menu and added to the edit task window.

Just to make sure it wasn't a merge issue, try out this branch I made with a merge of both.

https://github.com/jaredkaczynski/bird-bot/tree/mergedboth

raman325 commented 4 years ago

~sorry, to be more precise, when I open the "profile" drop down there is nothing but "Profile". I don't have any proxies set but when I click the drop down for that I see "Proxy List" and "None" so I think that one is loading correctly~

EDIT: nevermind, I didn't finish my rebase because of a conflict 🤦 it's all good, both PR's are working for me

natewong1313 commented 4 years ago

Thanks!