nateyolles / aem-developer-chrome

Chrome extension for AEM developers.
https://chrome.google.com/webstore/detail/aem-developer/hgjhcngmldfpgpakbnffnbnmcmohfmfc
MIT License
42 stars 10 forks source link

Use a cookie instead of a query param for wcmmode #16

Closed paul-bjorkstrand closed 9 years ago

paul-bjorkstrand commented 9 years ago

I added in some checking on the querystring param. It should now handle the situation when someone manually puts the param in properly, by removing the query string param and setting the cookie.

I know you are trying to remove jQuery, but I really like some of the features (like wrapping an array to make indexing out of bounds never error out)

nateyolles commented 9 years ago

Broke functionality. Add and Remove in edit no longer work. You should be able to: 1) click edit, enter a name and url, click + to save 2) click edit, click - to remove an entry and save 3) click edit, enter a name and url, without clicking +, click done to save

I like where this is going, let's just fix the lost functionality. I would also suggest one goal per pull request.