search

nateyolles / aem-developer-chrome

Chrome extension for AEM developers.
https://chrome.google.com/webstore/detail/aem-developer/hgjhcngmldfpgpakbnffnbnmcmohfmfc
MIT License
42 stars 10 forks source link

Revert "Use a cookie instead of a query param for wcmmode" #17

Closed nateyolles closed 9 years ago

nateyolles commented 9 years ago

Reverts nateyolles/aem-developer-chrome#16

Broke functionality. Add and Remove in edit no longer work. You should be able to: 1) click edit, enter a name and url, click + to save 2) click edit, click - to remove an entry and save 3) click edit, enter a name and url, without clicking +, click done to save

I like where this is going, let's just fix the lost functionality. I would also suggest one goal per pull request.

paul-bjorkstrand commented 9 years ago

Apologies for the broken functionality. I was trying to commit them separately, but I fat-fingered the last commit. I believe I have resolved that add/remove (with the fun addition of ordering as well). I will be committing that later and will test all the changed functionality before submitting another pull. For the future, I will take care to submit pulls for one piece at a time.