The hotkey doesn't work after updated to 0.14

[GoogleCodeExporter]

The hotkey doesn't work any more after updated to 0.14 on 2012/11/5. 
Firefox: 16.0.2
OS: ubuntu 12.04

Original issue reported on code.google.com by duguyip...@gmail.com on 5 Nov 2012 at 11:53

[GoogleCodeExporter]

Thanks for your bug report.

What hotkey are you using? I noticed that after upgrading to Firefox 16, the 
hotkey I was using (Ctrl + Shift + c) no longer worked because it had been 
taken by Firefox. I had to change it to a different combo (Ctrl + Shift + u), 
after which it worked again.

Let me know if this doesn't work for you, and I can try to gather more 
debugging information.

Original comment by nathan.i...@gmail.com on 5 Nov 2012 at 2:03

[GoogleCodeExporter]

Thank you for you replay.

I have tried alt+k, alt+j, and ctrl+alt+k. None of them works. And I don't 
think it is the problem of firefox, because after I degraded to version 0.13 
yesterday, it works great again. 

PS: I am using vimperator. But I have tried to disable all the keys, and the 
hotkey still doesn't work.

Original comment by duguyip...@gmail.com on 6 Nov 2012 at 12:39

[GoogleCodeExporter]

It's odd...I don't see anything in the code which would cause this problem.

If you are able, can you try following these steps with Color Toggle 0.14 
installed?

* Open a page (such as www.google.com)
* Press ctrl + shift + j to open the error console
* Click 'clear' on the error console
* Open the Color Toggle preferences window
* Change the hotkey (as above, I suggest ctrl + shift + u)
* Click 'OK' to save preferences and dismiss the window
* Press the hotkey

See if there are any relevant errors in the error console.

(You may see a warning about Mutation Events, this is a known issue 
(http://code.google.com/p/colortoggle/issues/detail?id=6) and should not affect 
the proper functioning of the hotkey).

Thanks!

Original comment by nathan.i...@gmail.com on 6 Nov 2012 at 4:07

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Maybe I know what happens, after the following steps. 

* I have tried the above steps. The hotkey (ctrl+shift+u) works well without 
any warning except the one you mentioned. 
* I changed the hotkey to alt+k again, it still works well without restarting 
firefox.
* After I restart firefox, alt+k no longer works, but ctrl+shift+u works again.
* I have tried some other hotkeys, the hotkey also turns back to ctrl+shift+u 
after restarting firefox.

Maybe there is something in the code that make the add-on initialize the hotkey 
as ctrt+shift+u every time.

Original comment by duguyip...@gmail.com on 6 Nov 2012 at 7:10

[GoogleCodeExporter]

I repeated your steps to reproduce (using alt + k as the hotkey) and had no 
problems - ctrl + shift + u had been unregistered and alt + k still worked 
after restart.

Please try the following steps:
* Set the hotkey to alt + k
* Restart firefox
* Verify that you have reproduced what you described above (c+s+u works and 
alt+k doesn't)
* Open a new tab and type about:config (if this is the first time, you will 
have to confirm that you know what you're doing. Say yes.)
* In the search bar along the top, type in "key_combo"
* You should see a line that says extensions.bgtoggle.key_combo
* Record what it says

Thanks again!

Original comment by nathan.i...@gmail.com on 6 Nov 2012 at 1:22

[GoogleCodeExporter]

It reads user set (status), string (Type), k,false,false,true (Value). But 
still ctrl+shift+u works and alt+k doesn't.

Original comment by duguyip...@gmail.com on 7 Nov 2012 at 12:42

[GoogleCodeExporter]

Ah, thanks for your update. I may have figured it out.

I can reproduce the behavior you're seeing occurs if I remove the status bar. 
Apparently having no status bar icon prevents the startup code from executing, 
meaning that the preference is never read and the hotkey remains at its default 
(which happens to be ctrl + shift + u).

I will have to re-read some of the Mozilla documentation, which has undoubtedly 
changed since I wrote this extension for Firefox 3.

I'm assuming that you've always had the status bar removed and you just used 
the hotkey to activate the extension, meaning that something I changed from 
0.13 to 0.14 may have broken that as a side effect (this is entirely possible, 
as adding the toolbar button meant messing around with the manifest).

In any case, now that I can reproduce the problem myself I hope to have a fix 
for you (and the others who are undoubtedly hitting this problem) in the next 
few days.

Original comment by nathan.i...@gmail.com on 7 Nov 2012 at 5:02

• Changed state: Accepted

[GoogleCodeExporter]

Thank you for your patience.

I am glad to know that you can reproduce the behavior I'm seeing. I have tried 
the steps you mentioned. I find that it is not the problem of the status bar 
but the tool bar button (i.e. the navigation toolbar button). I find that the 
hotkey works properly if and only if the tool bar button is shown in the tool 
bar (i.e. it is not hided in the Customize Toolbar dialogue.) And it works 
properly even if you remove the navigation toolbar itself after you draw the CT 
button to the toolbar.

Thanks again!

Original comment by duguyip...@gmail.com on 7 Nov 2012 at 7:47

[GoogleCodeExporter]

I believe I fixed the issue in version 0.15, which is under review. I will 
update when that version is live on the Mozilla site.

Original comment by nathan.i...@gmail.com on 7 Nov 2012 at 2:24

[GoogleCodeExporter]

Looks like 0.15 is live now. Please give it a spin and see if it addresses your 
problems!

Original comment by nathan.i...@gmail.com on 7 Nov 2012 at 10:39

[GoogleCodeExporter]

It works properly now. Thank you for your patience again!

Original comment by duguyip...@gmail.com on 8 Nov 2012 at 1:13

[GoogleCodeExporter]

Thank *you*, both for taking the time to file the bug report and for helping me 
narrow down the problem. It was a pleasure working with you!

Original comment by nathan.i...@gmail.com on 8 Nov 2012 at 2:33

• Changed state: Verified

[GoogleCodeExporter]

My pleasure!

Original comment by duguyip...@gmail.com on 8 Nov 2012 at 3:43