Open nkm8 opened 7 years ago
nathan-hega
commented
7 years ago Thank you for the recommendations and for checking the project out! Whenever I catch some free time I plan to circle back to this project and do something regarding the devops instruction/tutorial. I was leaning towards AWS since that is where my latest research has been.
nkm8
commented
7 years ago I think any cloud/devops approach you choose will be fine. My suggestions are stretch goals, anyway. I took a closer look at the code and everything looks great - clear/concise code with comments sprinkled in as necessary.
Out of curiosity, does Slack plan on replacing the slash commands with something else or are they 'legacy' due to reliability/scaling concerns?
nathan-hega
commented
7 years ago I just realized my notifications were still disabled from when I used this account at my last job, so I didn't see this message :X
My original README had it a bit backwards. Slash commands are not legacy, but the scheme in which I implemented this project is considered a "custom legacy integration" whereas Slack is pushing people to a "Slack app" approach (where Slash commands are still valid). I updated the README to reflect this information.
nkm8
commented
7 years ago Makes sense - slack politics 🎲
Both the readme and the code look great - extremely thorough and easy to follow. If you wanted to expand what you have included, I would suggest:
My comments above are based on hubot, which I consider to be extremely similar to slack-bots: Getting Started (with deployment examples) yeoman instructions
However, these are merely suggestions to include other useful tools/examples. I think what you have now is able to stand as-is for anyone to pick up and use with little effort. I would give it a shot, but I am not currently using Slack for anything.