search

nathan-osman / go-sunrise

Go package for calculating the sunrise and sunset times for a given location
MIT License
145 stars 17 forks source link

Fixed anomaly where sun does not rise or set #7

Closed FileGo closed 3 years ago

FileGo commented 3 years ago

This fixes issue #6 where does not rise or set. In this case, SunriseSunset now returns two time.Time{} values as indication that such condition has occured.

I've added a test for the condition as described, and it passess alongside with all existing tests.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-3.8%) to 96.25% when pulling 7835498a050383b11559b2366d8e5328bc4861ee on FileGo:6 into 7c449e7c690b1ad3692d399bb4e49fcf864428d6 on nathan-osman:master.

nathan-osman commented 3 years ago

Sorry I didn't see issue #6 when it was filed earlier.

Thanks for the merge request!