search

nathanaschbacher / nodiak

Nodiak is a Node.js client for the Riak Distributed Database
MIT License
43 stars 16 forks source link

Add Protocol Buffers backend w/ HTTP fallbacks #7

Open nathanaschbacher opened 12 years ago

nathanaschbacher commented 12 years ago

At some point a protobufs backend needs to be implemented.

I envision it mostly inheriting from the HTTPBackend the same way the HTTPSBackend does, but simply needing to replace/override more methods.

Off the top of my head, the request, responseHandler, GET, POST, PUT, HEAD, DELETE, headersToMetadata, and metadataToHeaders methods.

If those are reimplemented to use protobufs on the back, but mimic HTTP (like common status codes and header conversion), then everything should work fine. Keeping the protobufs support from leaking into implementation details outside the specific backend.

dcartertwo commented 10 years ago

+1 Would really like to see this feature in this library. Will be using https://github.com/nlf/riakpbc until this gets added

mchiodo commented 10 years ago

+1 for PBs

nathanaschbacher commented 9 years ago

So. I'm going to be finishing support for this for the upcoming Riak 2.0 client. Once completed I'll be backporting that implementation to the Riak 1.x client. So keep a lookout on Issue #25