ffprobe_path returns ffmpeg path

nathanbabcock / ffmpeg-sidecar

Wrap a standalone FFmpeg binary in an intuitive Iterator interface. 🏍

MIT License

238 stars 16 forks source link

ffprobe_path returns ffmpeg path #20

Closed prabirshrestha closed 11 months ago

prabirshrestha commented 12 months ago

ffprobe_path() uses sidecar_path() which hardcodes .join('ffmepg').

Seems like it needs ffmpeg_sidecar_path() and ffprobe_sidecar_path().

nathanbabcock commented 11 months ago

@prabirshrestha thanks for pointing this out.

I'll merge a PR with the quick fix -- however I'll address this more thoroughly when also investigating using ffmpeg-static as the source of binaries. That will address a few other outstanding issues:

Download path differs between cargo test, cargo run, and cargo run --example -- and sometimes the downloaded binary can't be found
Some distributions do not include ffprobe in the first place