search

nathanboktae / chai-dom

DOM assertions for the Chai assertion library using vanilla JavaScript
Other
76 stars 26 forks source link

Asserting checkbox checked state? #39

Closed lolmaus closed 2 years ago

lolmaus commented 5 years ago

Currently doing this:

expect(checkbox.checked).to.be.true;

I believe, it would read much better as:

expect(checkbox).to.be.checked;

CC @simonihmig

lolmaus commented 3 years ago

Please??

nathanboktae commented 3 years ago

I like it - I'll accept a PR for the feature!

lolmaus commented 3 years ago

Can you please provide some guidance?

nathanboktae commented 3 years ago

See #53 - prime example of adding a new assertion with documentation and tests.

lolmaus commented 2 years ago

Done: https://github.com/nathanboktae/chai-dom/pull/56 .

lolmaus commented 2 years ago

@nathanboktae Thanks! Are you gonna release it?