search

nathanboktae / mocha-casperjs

Write CasperJS tests using Mocha
MIT License
120 stars 29 forks source link

Fix problem with steps counter #108

Closed evgenijponomarev closed 7 years ago

evgenijponomarev commented 7 years ago

Issue #107

evgenijponomarev commented 7 years ago

@nathanboktae, it's all right? Would you like some changes?

evgenijponomarev commented 7 years ago

I made 2 commits: the first one fixes the problem with skipping the first step in the test after the failure. In the second - the solution of the problem with the continuation of the test after its failure.

nathanboktae commented 7 years ago

OK thanks I like this version a lot better since it's using a public API of casper. Thanks also for the extended tests!

It's a change of behavior in how steps are skipped on failed so I'll have to go to 0.6.0. Let me review it more in the next day or two to find anything else, thanks.

nathanboktae commented 7 years ago

Thanks! I compressed the 6 tests down to 4 and remove the google dependency (I don't even think they support http anymore, thanks 'murica). If CI is good I'll release 0.6.0 soon.