search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Exit with 1 if no exit code at all #121

Closed cody- closed 10 years ago

cody- commented 10 years ago

In case of PhantomJS crash code will be equal to null and will be converted to 0 (SUCCESS) - so we need to exit with some error code in such case.

arikon commented 10 years ago

:+1:

nathanboktae commented 10 years ago

In normal execution, mocha-phantomjs sets the exit code to thenumber of tests that failed. Use a negative number and it should be fine.

cody- commented 10 years ago

@nathanboktae fixed

nathanboktae commented 10 years ago

cool thanks!

metaskills commented 10 years ago

Just published v3.3.2. Thanks y'all!