search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Add phantomjs as a peer dependency #132

Closed nathanboktae closed 10 years ago

nathanboktae commented 10 years ago

As discussed in #127 and a hopeful fix #125 , this PR addes phantomjs as a peer dependency. This will also make installation easier, especially for local installs, and clearly expresses our version requirements on phantomjs.

nathanboktae commented 10 years ago

@metaskills How does this look to you?

metaskills commented 10 years ago

Yea, I just did a read up on peerDependencies and this looks great. Thanks for taking the time to get this in Nathan! BTW, is there a way I can allow you to publish to npm too?

nathanboktae commented 10 years ago

Cool thanks.

BTW, is there a way I can allow you to publish to npm too?

npm owner add nathanboktae mocha-phantomjs
metaskills commented 10 years ago

DONE! https://www.npmjs.org/package/mocha-phantomjs