search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Improve PhantomJS version check so PhantomJS 2 can be used as well. #148

Closed daanwissing closed 10 years ago

daanwissing commented 10 years ago

I tried to use PhantomJS 2 (still in development) with mocha-phantomjs and stumbled on this version checking which excluded me from trying it. It looks like everything works, except that some tests keep failing on my machine (even without these modifications).

nathanboktae commented 10 years ago

Cool thanks.

Where did you get the build of PhantomJS 2? Is it chromium based? I'd like to try this out too. I thought they were skipping 2 (which was QT 5 based) and going to 3 (chromium based).

metaskills commented 10 years ago

Second that, would love to learn more.

daanwissing commented 10 years ago

Well, as far as I know PhantomJS 2 is still in development phase, but currently on their master branch. I got a nightly build here, but it does not work that well yet with mocha-phantomjs. I tried building it myself, but making a windows build myself proved to be difficult and it failed. Finally, I got an older build from somewhere I can't remember (sorry), which worked for me.

I have no idea about which version is going to be released. I just wanted to try it with a working ECMA5 implementation so my code could get properly tested. For some hints on building it on windows, check my issue here: https://github.com/ariya/phantomjs/issues/12445