search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Phantomjs, mocha, commander dependency versions aren't strict #166

Closed mwoc closed 9 years ago

mwoc commented 9 years ago

mocha-phantomjs has a peer and dev dependency for phantomjs ~1.9.1.

When running npm install in the mocha-phantomjs package, it will install phantomjs 1.9.12.

I don't know if that is intended by mocha-phantomjs or not. If it's not intended, the tilde should probably be dropped, so it'll depend on a precise version. If it is intended, I suggest changing the dependency to the following so it's more explicit:

"phantomjs": "1.9.x"

The same as above counts for the Mocha and Commander dependencies.

metaskills commented 9 years ago

Well, 1.9.x would allow 1.9.0 and that version did not have stdout/err yet.

nathanboktae commented 9 years ago

I would not want to lock to a patch version, and as @metaskills pointed out we have to use ~1.9.1 to exclude 1.9.0.

If people adhere to semver, patch versions should never break dependents. I has happened, but there is more pain into locking a patch version, especially with peer dependencies.