search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

Can not specify phantomjs cookies-file #182

Closed thomasphorton closed 9 years ago

thomasphorton commented 9 years ago

Looked through the issues and didn't see anything reported. Would it be possible to pass a flag through to phantomjs to specify --cookies-file?

http://phantomjs.org/api/command-line.html

If there isn't a technical reason for not supporting this feature, maybe all flags that aren't recognized by mocha-phantomjs should be passed through.

Thoughts? I can work on it if it isn't something that has already been discussed and shot down.

nathanboktae commented 9 years ago

maybe all flags that aren't recognized by mocha-phantomjs should be passed through

Yes we should really be doing this, and would love a PR to do so. Thanks!

thomasphorton commented 9 years ago

Cool- I'll try and schedule some time for it.

thomasphorton commented 9 years ago

Just hard-coding the argument into the phantomJS call gives me an unsafe access error for loading a cookies.txt that lives in the test directory. Looking a little deeper.

nathanboktae commented 9 years ago

Tracking this in #186