search

nathanboktae / mocha-phantomjs

:coffee: :ghost: Run client-side mocha tests in the command line through phantomjs
MIT License
954 stars 112 forks source link

use require.resolve to fetch script file of mocha-phantomjs-core #204

Closed kaelzhang closed 9 years ago

kaelzhang commented 9 years ago

The new NPM(version 3.3.3) will install dependencies directly into the node_modules directory as much as possible rather than installing them hierarchically.

So, there might not be a node_modules directory inside node_modules/mocha-phantomjs/, see here

It's better to do the path.resolve thing with require.resolve()

nathanboktae commented 9 years ago

Good catch, thanks.

nathanboktae commented 9 years ago

4.0.1 has your fix. Thanks.

kaelzhang commented 9 years ago

You are so efficient, buddy! :+1:

nathanboktae commented 9 years ago

Yeah 10min from open to fix and published is a new record for me :)