search

nathanbuchar / electron-settings

📝 A simple persistent user settings framework for Electron.
https://electron-settings.js.org
MIT License
817 stars 60 forks source link

Replace `write-file-atomic` with `atomically` #174

Closed quanglam2807 closed 1 year ago

quanglam2807 commented 1 year ago

Resolve #159 Resolve #169

CC: @nathanbuchar

Reference: https://github.com/sindresorhus/electron-store/issues/103

nathanbuchar commented 1 year ago

Thank you!

nathanbuchar commented 1 year ago

I'll deploy this tonight.

quanglam2807 commented 1 year ago

Thanks so much, @nathanbuchar. For releasing, you'll probably need to modify src/settings.ts to drop remote support.

You can check out my fork for referencing: https://github.com/webcatalog/electron-settings/commit/9db71fdb4ef784d73319e1ff120af2d8508e6ae1#diff-bb57a3bd912abc3ec2e729cb8a743838487677a5517683d0c8913a3619ac296a

If possible, I'd love to join as a maintainer of this project.

nathanbuchar commented 1 year ago

@quanglam2807 sorry, didn't get around to it tonight. I'd be happy to add you as a maintainer, as I haven't used Electron in years. if you get this fully ready, I'll publish a new version.

quanglam2807 commented 1 year ago

Np! Please add me as GitHub maintainer, @nathanbuchar. We'll need to do multiple things (multiple PRs) to get the project back to track so it would be much more productive if I'm a maintainer.

nathanbuchar commented 1 year ago

I sent the Github collaborator invite over to you last night, but I see it's still marked as pending.

quanglam2807 commented 1 year ago

@nathanbuchar Thank you! It's ready for release now.

nathanbuchar commented 1 year ago

Excellent. Many thanks for your help and your agency for keeping this repository properly maintained. I have just published v5.0.0 to npm (@latest). Please install the latest version and make sure everything was properly published and working as expected.

For future reference, I run npm run release to automatically boost the version number and update the changelog, so as long as you use the Conventional Commits spec correctly, the release script will automatically boost to the proper semantic version without needing to modify the package.json manually.

I don't suppose the tests are working with your most recent changes? I wasn't able to test things locally, but I don't currently have Electron installed. Would be good to have tests functional in some sort of CI (I was using Travis before) as a sanity test for future PRs.

Thanks again!

jabdinghoff commented 2 months ago

What exactly happened to the 5.0.0 release and this merge?

nathanbuchar commented 2 months ago

This released, but immediately introduced #178, so I rolled back. I am not really actively maintaining this, and @quanglam2807 disappeared after pushing this so I wasn't able to get his help. Open to (stable) PRs :)