nathancahill / split

Unopinionated utilities for resizeable split views
https://split.js.org/
MIT License
6.1k stars 448 forks source link

[Split-Grid]: typo in typescript types #784

Open nclemeur opened 1 year ago

nclemeur commented 1 year ago

I believe that the types definitions should be fixed for GridTemplateProperty: export type GridTemplateProperty = 'grid-template-column' | 'grid-template-row';

It should be export type GridTemplateProperty = 'grid-template-columns' | 'grid-template-rows';

(note the extra 's' at the end)

nathancahill commented 1 year ago

Thanks, can you submit a PR with this change?

nclemeur commented 1 year ago

I have tried, but this is a bit of a new process for m, so hopefully it will be fine

kotasudhakar commented 1 year ago

this issue is good to be closed i guess

nclemeur commented 1 year ago

Thank you