search

nathancarter / group-explorer

Group theory visualization software in the browser
http://nathancarter.github.io/group-explorer/index.html
222 stars 26 forks source link

Clarify whether interested in group submissions #10

Closed kcrisman closed 4 years ago

kcrisman commented 4 years ago

Group Explorer is great! Is it interested in additional groups, or is the "canon closed", so to speak? Either way, this should be on the readme, I think.

nathancarter commented 4 years ago

We have in there most of the groups that it's reasonable to visualize, and a few that it isn't. :) It's not too hard to export a group from GAP to GE, so any requests for specific groups aren't too hard to honor. (In fact, these lines of code automate most of it.)

kcrisman commented 4 years ago

We have in there most of the groups that it's reasonable to visualize, and a few that it isn't. :)

True!

It's not too hard to export a group from GAP to GE, so any requests for specific groups aren't too hard to honor. (In fact, these lines of code https://github.com/nathancarter/gap-pkg-groupexplorer/blob/master/lib/main.gi#L23-L30 automate most of it.)

Anyway, maybe something about this (or desired contributions in general) should be added in a contributing.md or something.

nathancarter commented 4 years ago

OK I updated the README.md just now with a contributing section.

kcrisman commented 4 years ago

Great!

On Wed, Sep 9, 2020 at 10:21 AM Nathan Carter notifications@github.com wrote:

Closed #10 https://github.com/nathancarter/group-explorer/issues/10.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nathancarter/group-explorer/issues/10#event-3746117739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANRQ4BAJGYR2MHVDBLTT63SE6FNDANCNFSM4Q77NMWQ .

rayellis4 commented 3 years ago

Just FYI, there are another 80 or so groups in fgb_groups, you can access them individually with a URL like http:/.../GroupInfo.html?groupURL=fgb_groups/Order32Number07.group and it wouldn't be hard to put something together so you could download them all at once. (I haven't tried this recently, but if it doesn't work I'm sure it's something minor.) It's easy to add to the canon, too -- just add a line to the file GroupURLs.js .

There are two things about the number of files I was concerned with: 1) the initial download can take a while (though this has become a non-problem in recent times) 2) the groups are cached in local storage, which is limited (especially on tablets), and the current implementation is pretty graceless about dealing with overruns The size of the group representation in memory isn't much of a problem, btw -- all the groups together take up about as much memory as a good-sized jpg or two.

-- Ray

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nathancarter/group-explorer/issues/10#issuecomment-689632055, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKE4RFNHJELWWDYUS7RKZSTSE6MFXANCNFSM4Q77NMWQ .

kcrisman commented 3 years ago

There are two things about the number of files I was concerned with: 1) the initial download can take a while (though this has become a non-problem in recent times)

I did actually notice this taking a nontrivial amount of time to load up initially sometimes. Depends on the wifi. So there is that, you are right.