search

nathancarter / group-explorer

Group theory visualization software in the browser
http://nathancarter.github.io/group-explorer/index.html
222 stars 26 forks source link

make sure prime cyclic groups are simple #13

Closed kcrisman closed 3 years ago

kcrisman commented 4 years ago

I think that || evaluates like in Python, where if the first one is true then it just immediately returns true, right? Otherwise we should keep the line about >2.

nathancarter commented 3 years ago

So close! One tiny thing to tweak! The = in JavaScript is assignment only, not equality comparison. Just use == instead and this is ready to merge. Thanks a lot for the work!

kcrisman commented 3 years ago

Sorry, that was just carelessness - wouldn't have happened a decade ago! I don't contribute code more than about .1% of my time nowadays ☹️ Thanks for catching that.

<rant>Javascript always silently fails in such situations in web interfaces, so you have to really have an eagle eye. Aargh.</rant>

nathancarter commented 3 years ago

Thanks again!!